-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Maps Not Working on First Run #2379
Comments
Just to add that I've found this bug in my own project too but occasionally source maps will work on first run. Perhaps about 1 time in 10 runs it will work first time without needing a reload. I thought it was worth mentioning since this possibly indicates a race condition. |
Not able to reproduce in v0.33.3, seems to have been fixed when updating Chrome. |
Still Experiencing this in v0.33.4. Here's a 34 second video recreating the bug: https://www.dropbox.com/s/r883d31jm1bpb9c/electron-sourcemaps-test.mov?dl=1 (39MB .mov) And here's a repo of the code that I used, you can clone it to hopefully reproduce this on your dev environment: https://github.com/davej/electron-sourcemaps-test |
I observe this issue on osx 10.11.
|
Just re-tested this with 1.4.4 and I can confirm this is still broken. Also updated the test case repo. |
Closing due to abandonment. |
@codebytere: What does 'abandonment' mean in this case? There is a test case repo, a video and 5 thumbs up indicating that other people are experiencing this issue. Would you like me to confirm that the issue still exists in the latest version of Electron? |
That would be great, thanks! We're just weeding out abandoned issues (issues that have seen no action in a significant amount of time) so if this is still an issue and you feel it's important to fix i'll definitely reopen it :) |
Just re-tested this with 1.7.8 and I can confirm this is still broken. Also updated the test case repo. @codebytere: Can you please consider reopening. |
we're just weeding out abandoned issues, so if this is still in need of a fix i'll reopen :) |
[Off-topic: Feedback about marking issues as 'abandoned' (click to expand)]@codebytere Thanks! I understand the desire to lower the number of open issues but "abandonment" seems like a short-sighted criteria. Often people don't want to spam an issue with "me too" comments when the issue is already described and they have no useful information to add. Please consider removing the "abandonment" reason for closing issues because it doesn't relate to the content of an issue. Closing issues because the team have decided they are "Wont fix" or "Can't reproduce" (or whatever) seems reasonable instead. I noticed that #4368 was closed too, even though the bug still seems to be present. Thanks for your help 🙂, sorry for going off-topic. |
@davej thanks for the input! i'll be more verbose in the future so that people can better understand why i might be closing something 😁 |
I recently updated from webpack 1 to webpack 3.10, and am now also experiencing this issue:
|
I'm using Webpack 4 and am also experiencing this issue. |
I’ve fixed this in my app by waiting for devtools to open before navigating with loadURL/loadFile. It makes sense that the Chrome debugger needs to be running to transform source maps. To me this seems like a Chrome issue, and not something Electron should try to fix. |
Expanding on what @mattdesl referred to, here is a snippet of code that waits for a
|
This makes sense to me, based on the workaround it sounds like devtools needs to be open to fetch and parse these. Gonna close this one out 👍 |
Update... for me, as of Electron 8, waiting for the 'devtools-opened' event stopped opening the devtools at all. The only way I could get devtools opened at that point was to hit ctrl-shift-i twice in fast succession. I've gone back to just attempting to open them without waiting for the signal, and crossing my fingers that the timing/source-map issue is fixed.
Another option if the problem comes back might be to use the new method of opening the devtools in a separate window:
|
Hey,
I've noticed that source maps are not applied on first run. After launching Electron, the user needs to re-load the page in order for the source maps to "kick in."
Here is a repo where you can reproduce the problem:
test-electron-source-maps (in branch test/first-run)
The text was updated successfully, but these errors were encountered: