Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add patch to prevent crash during frame swap with ctx isolation enabled #23896

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 2, 2020

Backport of #23684

See that PR for details.

Notes: Fixed crash when navigating between origins in a child window with nativeWindowOpen and contextIsolation enabled

@trop trop bot requested a review from a team as a code owner June 2, 2020 01:03
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2020
@trop trop bot requested a review from MarshallOfSound June 2, 2020 01:03
@trop trop bot added 10-x-y backport This is a backport PR labels Jun 2, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2020
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch needs update.

@MarshallOfSound MarshallOfSound force-pushed the trop/10-x-y-bp-fix-add-patch-to-prevent-crash-during-frame-swap-with-ctx-isolation-enabled-1591059813456 branch from 4eb0ed6 to 40fcbb3 Compare June 2, 2020 09:31
@MarshallOfSound MarshallOfSound merged commit 87cd20b into 10-x-y Jun 2, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 2, 2020

Release Notes Persisted

Fixed crash when navigating between origins in a child window with nativeWindowOpen and contextIsolation enabled

@MarshallOfSound MarshallOfSound deleted the trop/10-x-y-bp-fix-add-patch-to-prevent-crash-during-frame-swap-with-ctx-isolation-enabled-1591059813456 branch June 2, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants