feat: add app.getApplicationInfoForProtocol API #24112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
georgexu99
changed the title
codebytere
reviewed
Jun 12, 2020
MarshallOfSound
requested changes
Jun 17, 2020
georgexu99
changed the title
codebytere
reviewed
Jun 18, 2020
MarshallOfSound
changed the title
|
@electron/wg-api reviewed and approved this at our June 29, 2020 meeting |
georgexu99
changed the title
MarshallOfSound
approved these changes
Jun 30, 2020
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Release Notes Persisted
|
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
* pre merge * windows changes * added tests * clean up * more cleanup * lint error * windows 7 support * added windows 7 implementation * code review * lint and code review * code review * app.md merge conflict * merge conflict app.md accidently deleted code block * 'lint' * mis-moved getapplicationinfoforprotocol() into anonymous namespace * fix test * lint * code review
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
* pre merge * windows changes * added tests * clean up * more cleanup * lint error * windows 7 support * added windows 7 implementation * code review * lint and code review * code review * app.md merge conflict * merge conflict app.md accidently deleted code block * 'lint' * mis-moved getapplicationinfoforprotocol() into anonymous namespace * fix test * lint * code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This api returns the name, display icon and path of the application registered as the default handler of a specific protocol (eg. the protocol 'https://example.com' would return 'Chrome', Chrome's icon and its installation path (or whichever your default browser happens to be).
It's an extension of the "getApplicationNameForProtocol" api to allow for more information on the application to be returned
Checklist
npm testpassesRelease Notes
Notes: Added
app.getApplicationInfoForProtocol()API that returns detailed information about the app that handles a certain protocol