Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make sure tests fail properly instead of timing out #24316

Merged
merged 1 commit into from Jun 30, 2020
Merged

test: make sure tests fail properly instead of timing out #24316

merged 1 commit into from Jun 30, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 26, 2020 •
edited

Description of Change

Makes the tests fail properly instead of timing out:

  • either wrap expect() in try / catch
  • or re-implement test with async / await

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • PR title follows semantic commit guidelines
  • This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2020
@miniak miniak changed the title tests: don't use expect in async callbacks, use async function instead tests: don't use expect in async callbacks, use await/async instead Jun 26, 2020
@miniak miniak changed the title tests: don't use expect in async callbacks, use await/async instead test: don't use expect in async callbacks, use await/async instead Jun 26, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2020
@miniak miniak changed the title test: don't use expect in async callbacks, use await/async instead test: don't use expect in async callbacks, use async/await instead Jun 26, 2020
@miniak miniak force-pushed the miniak/async-tests branch 4 times, most recently from ea4098a to 6528bcf Compare June 26, 2020 18:32
@miniak miniak force-pushed the miniak/async-tests branch 8 times, most recently from 21e5c5f to ec99950 Compare June 26, 2020 23:09
@miniak miniak changed the title test: don't use expect in async callbacks, use async/await instead test: make sure tests fail properly instead of timing out Jun 26, 2020
@miniak miniak force-pushed the miniak/async-tests branch 4 times, most recently from e7796f9 to a26b9ab Compare June 27, 2020 00:05
@miniak miniak requested a review from alexeykuzmin June 27, 2020 00:16
@miniak miniak marked this pull request as ready for review June 27, 2020 00:17
alexeykuzmin
alexeykuzmin suggested changes Jun 27, 2020
View reviewed changes
spec/webview-spec.js Outdated Show resolved Hide resolved
spec/webview-spec.js Show resolved Hide resolved
spec/chromium-spec.js Outdated Show resolved Hide resolved
spec/chromium-spec.js Outdated Show resolved Hide resolved
spec/chromium-spec.js Outdated Show resolved Hide resolved
spec/chromium-spec.js Outdated Show resolved Hide resolved
spec/chromium-spec.js Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/async-tests branch 2 times, most recently from 31810bb to 4879eef Compare June 28, 2020 14:40
@miniak miniak requested a review from alexeykuzmin June 28, 2020 14:45
@miniak miniak force-pushed the miniak/async-tests branch 4 times, most recently from 1df665d to 3fe6e49 Compare June 28, 2020 16:36
@miniak miniak requested review from codebytere and zcbenz June 28, 2020 16:46
@alexeykuzmin alexeykuzmin merged commit c6db471 into master Jun 30, 2020
@alexeykuzmin alexeykuzmin deleted the miniak/async-tests branch June 30, 2020 22:10
@release-clerk
Copy link

release-clerk bot commented Jun 30, 2020

No Release Notes

miniak added a commit that referenced this pull request Jun 30, 2020
@miniak
test: make sure tests fail properly instead of timing out (#24316)
239690a
@miniak miniak mentioned this pull request Jun 30, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jun 30, 2020

@miniak has manually backported this PR to "10-x-y", please check out #24372

codebytere pushed a commit that referenced this pull request Jul 4, 2020
@miniak
test: make sure tests fail properly instead of timing out (#24372)
30cb2b1 
* test: use delay() helper (#24321)

* test: make sure tests fail properly instead of timing out (#24316)

* test: remove defer()

Co-authored-by: Milan Burda <miburda@microsoft.com>
@trop trop bot added the merged/10-x-y label Jul 4, 2020
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@miniak @sentialx
test: make sure tests fail properly instead of timing out (electron#2…
0201925 
…4316)
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@miniak @sentialx
test: make sure tests fail properly instead of timing out (electron#2…
3d06ec4 
…4316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @alexeykuzmin @codebytere