build: build squirrel and its dependencies from source #24318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
squirrel-src
branch
from
283ed9e
to
3fdbc03
Compare
nornagon
reviewed
Jun 26, 2020
MarshallOfSound
force-pushed
the
squirrel-src
branch
from
38dc752
to
8306ed0
Compare
ahallicks
reviewed
Jun 29, 2020
nornagon
requested changes
Jun 29, 2020
patches/ReactiveObjC/build_conditionally_import_ext_headers_from_framework_or_from.patch
Show resolved
Hide resolved
nornagon
approved these changes
Jul 2, 2020
|
No Release Notes |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
* build: build squirrel and its dependencies from source * chore: do not use fork for squirrel.mac * build: do not ship headers with dependency frameworks * Update BUILD.gn * chore: s/striped/stripped * chore: update as per feedback * chore: use ARC and fix build errors * chore: fix ARC Squirrel self retainer
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
* build: build squirrel and its dependencies from source * chore: do not use fork for squirrel.mac * build: do not ship headers with dependency frameworks * Update BUILD.gn * chore: s/striped/stripped * chore: update as per feedback * chore: use ARC and fix build errors * chore: fix ARC Squirrel self retainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our build to build
Squirrel.framework,Mantle.frameworkandReactiveObjC.frameworkfrom source (Used to beReactiveCocoa.framework). Things that changed:external-binariesBUILD.gnfile to Squirrel.Mac to build the three frameworksReactiveObjC(a renamed and slightly newer version of ReactiveCocoa)ReactiveCocoaas the way it consumes headers doesn't quite work with the interesting way that GN builds framework filesSquirrel.Mac GN Changes: electron/Squirrel.Mac@c718606
This needs to be a fork commit as it needs a
DEPSfile to be processed.We have a E2E updater test (phew) so this is as safe as this change is gonna get.
Notes: no-notes