Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in doc/tutorial/electron-versioning.md #24362

Merged
merged 1 commit into from
Jul 6, 2020
Merged

docs: fix typos in doc/tutorial/electron-versioning.md #24362

merged 1 commit into from
Jul 6, 2020

Conversation

jienius
Copy link
Contributor

@jienius jienius commented Jun 30, 2020

Description of Change

Small fixes for a couple of typos I found

Checklist

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Jun 30, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2020
@vhashimotoo vhashimotoo requested a review from a team June 30, 2020 13:22
@erickzhao erickzhao self-requested a review June 30, 2020 16:56
docs/tutorial/electron-versioning.md Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 1, 2020
@jienius jienius requested a review from erickzhao July 1, 2020 17:56
@malept
Copy link
Member

malept commented Jul 1, 2020

Can you please fill out the pull request template and paste it into the pull request summary?

Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jienius!

@jkleinsc jkleinsc merged commit b0be3fb into electron:master Jul 6, 2020
@welcome
Copy link

welcome bot commented Jul 6, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jul 6, 2020

No Release Notes

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants