New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add child-process-gone event to app #24367
Conversation
fbc7800
to
bac7f6a
Compare
83cfcf7
to
46ff7f6
Compare
33d5bcc
to
9f9b27a
Compare
@@ -403,6 +408,36 @@ Returns: | |||
Emitted when the renderer process unexpectedly dissapears. This is normally | |||
because it was crashed or killed. | |||
|
|||
#### Event: 'child-process-gone' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awkward naming because of the child_process module in node. Is there another name we can use for this that wouldn't conflict with that existing concept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is a different enough context that the namespace collision doesn't bother me, and it's valuable i think to match Chromium's naming where possible.
The API WG approved this PR at our July 13th 2020 meeting |
9f9b27a
to
7002eea
Compare
Release Notes Persisted
|
Description of Change
Allows reporting utility process issues in application telemetry. Is also replaces the
gpu-process-crashed
event. It gives more information about what happened to the process similar torender-process-gone
.Examples:
child-process-gone { type: 'Utility', reason: 'killed', name: 'Network Service' }
child-process-gone { type: 'Utility', reason: 'killed', name: 'Audio Service' }
child-process-gone { type: 'GPU', reason: 'killed' }
Checklist
npm test
passesRelease Notes
Notes: Added
utility-process-gone
event toapp
.