Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add child-process-gone event to app #24367

Merged
merged 1 commit into from Jul 20, 2020
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 30, 2020

Description of Change

Allows reporting utility process issues in application telemetry. Is also replaces the gpu-process-crashed event. It gives more information about what happened to the process similar to render-process-gone.

Examples:

  • child-process-gone { type: 'Utility', reason: 'killed', name: 'Network Service' }
  • child-process-gone { type: 'Utility', reason: 'killed', name: 'Audio Service' }
  • child-process-gone { type: 'GPU', reason: 'killed' }

Checklist

Release Notes

Notes: Added utility-process-gone event to app.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2020
@miniak miniak self-assigned this Jun 30, 2020
@miniak miniak force-pushed the miniak/utility-process-gone branch from fbc7800 to bac7f6a Compare June 30, 2020 15:31
@miniak miniak changed the title feat: add utility-process-gone event to app feat: add child-process-gone event to app Jun 30, 2020
@miniak miniak force-pushed the miniak/utility-process-gone branch 4 times, most recently from 83cfcf7 to 46ff7f6 Compare June 30, 2020 15:54
@miniak miniak force-pushed the miniak/utility-process-gone branch 2 times, most recently from 33d5bcc to 9f9b27a Compare June 30, 2020 22:00
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 1, 2020
@@ -403,6 +408,36 @@ Returns:
Emitted when the renderer process unexpectedly dissapears. This is normally
because it was crashed or killed.

#### Event: 'child-process-gone'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awkward naming because of the child_process module in node. Is there another name we can use for this that wouldn't conflict with that existing concept

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is a different enough context that the namespace collision doesn't bother me, and it's valuable i think to match Chromium's naming where possible.

@jkleinsc
Copy link
Contributor

The API WG approved this PR at our July 13th 2020 meeting

@miniak miniak force-pushed the miniak/utility-process-gone branch from 9f9b27a to 7002eea Compare July 16, 2020 13:37
@jkleinsc jkleinsc merged commit fa1323d into master Jul 20, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 20, 2020

Release Notes Persisted

Added utility-process-gone event to app.

@jkleinsc jkleinsc deleted the miniak/utility-process-gone branch July 20, 2020 14:34
georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants