Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding Documentation for Open Recent Menu-item #24374

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

bhutraraghav
Copy link
Contributor

@bhutraraghav bhutraraghav commented Jun 30, 2020

docs: Solving issue #22018, adapting the additions made by PR #11166, i.e. adding documentation for adding menu-item for opening recent files.

Notes: none.

@welcome
Copy link

welcome bot commented Jun 30, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2020
@bhutraraghav bhutraraghav changed the title Adding Documentation for Open Recent Menu-item docs: Adding Documentation for Open Recent Menu-item Jun 30, 2020
@vhashimotoo vhashimotoo requested a review from a team June 30, 2020 23:21
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 1, 2020
docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change to make, but mostly LGTM. In the long run, I don't think bolding stuff is the best way to organize this doc, but I think it's good enough (follows set existing pattern set in the rest of the doc).

docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
docs/tutorial/recent-documents.md Outdated Show resolved Hide resolved
@codebytere
Copy link
Member

@bhutraraghav can you push an empty commit or force push to fix the lint check?

@bhutraraghav bhutraraghav force-pushed the master branch 2 times, most recently from 28792b0 to ac70668 Compare July 16, 2020 07:20
@bhutraraghav
Copy link
Contributor Author

bhutraraghav commented Jul 16, 2020

@bhutraraghav can you push an empty commit or force push to fix the lint check?

@codebytere Tried both but didn't work!

bhutraraghav and others added 2 commits July 23, 2020 09:57
- Solves issue electron#22018, adapting the changes made by PR#11166
- Update docs/tutorial/recent-documents.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>
@codebytere codebytere merged commit ec838cf into electron:master Jul 23, 2020
@welcome
Copy link

welcome bot commented Jul 23, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jul 23, 2020

Release Notes Persisted

none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants