Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix build with context snapshot disabled #24433

Merged
merged 1 commit into from
Jul 6, 2020
Merged

build: fix build with context snapshot disabled #24433

merged 1 commit into from
Jul 6, 2020

Conversation

MarshallOfSound
Copy link
Member

Fixes gn gen when use_v8_context_snapshot is disabled

Notes: no-notes

@MarshallOfSound MarshallOfSound merged commit 99079c3 into master Jul 6, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 6, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the fix-no-ctx-snap branch July 6, 2020 18:11
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@MarshallOfSound @sentialx
build: fix build with context snapshot disabled (electron#24433)
20b6db4
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@MarshallOfSound @sentialx
build: fix build with context snapshot disabled (electron#24433)
a9de94a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
Apple Silicon 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @jkleinsc @codebytere