Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chrome://accessibility not loading #24437

Merged
merged 12 commits into from Jul 16, 2020
Merged

fix: chrome://accessibility not loading #24437

merged 12 commits into from Jul 16, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 6, 2020 •
edited

Description of Change

Closes #24403.

Adds appropriate resources to make chrome://accessibility work once more.

Tested with https://gist.github.com/a2621c409a05ed034b95662566471675

Screen Shot 2020-07-06 at 6 44 59 PM

cc @deepak1556 @zcbenz @MarshallOfSound

Checklist

Release Notes

Notes: Fixes chrome://accessibility access in Electron.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 6, 2020
@codebytere codebytere changed the title Fix a11y page fix: chrome://accessibility not loading Jul 6, 2020
@codebytere codebytere force-pushed the fix-a11y-page branch 3 times, most recently from ea345f7 to 8bb759b Compare July 7, 2020 01:43
@codebytere codebytere marked this pull request as ready for review July 7, 2020 01:43
@codebytere codebytere requested a review from a team as a code owner July 7, 2020 01:43
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 7, 2020
@codebytere codebytere changed the title fix: chrome://accessibility not loading [wip] fix: chrome://accessibility not loading Jul 14, 2020
@codebytere codebytere force-pushed the fix-a11y-page branch 4 times, most recently from 14b48b0 to 312e5fc Compare July 14, 2020 16:02
@codebytere codebytere changed the title [wip] fix: chrome://accessibility not loading fix: chrome://accessibility not loading Jul 14, 2020
deepak1556
deepak1556 reviewed Jul 14, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just minor style changes

chromium_src/chrome/browser/accessibility_ui.h Outdated Show resolved Hide resolved
chromium_src/chrome/browser/accessibility_ui.h Outdated Show resolved Hide resolved
chromium_src/chrome/browser/accessibility_ui.cc Outdated Show resolved Hide resolved
deepak1556
deepak1556 reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes.

shell/browser/api/electron_api_base_window.h Outdated Show resolved Hide resolved
shell/browser/native_window.cc Show resolved Hide resolved
shell/browser/native_window.h Outdated Show resolved Hide resolved
shell/browser/native_window.cc Outdated Show resolved Hide resolved
shell/browser/ui/webui/accessibility_ui.cc Outdated Show resolved Hide resolved
shell/browser/ui/webui/accessibility_ui.cc Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the fix-a11y-page branch 3 times, most recently from deae20f to fd6077a Compare July 15, 2020 23:26
deepak1556
deepak1556 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codebytere codebytere merged commit 3f37ff8 into master Jul 16, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 16, 2020

Release Notes Persisted

Fixes chrome://accessibility access in Electron.

@codebytere codebytere deleted the fix-a11y-page branch July 16, 2020 17:15
georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
@codebytere @MarshallOfSound
fix: chrome://accessibility not loading (electron#24437)
0081a04
georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
@codebytere @MarshallOfSound
fix: chrome://accessibility not loading (electron#24437)
6d5f791
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@codebytere @sentialx
fix: chrome://accessibility not loading (electron#24437)
09e33cc
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
fix: chrome://accessibility not loading (electron#24437)
e29cd95
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
fix: chrome://accessibility not loading (electron#24437)
3118cc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chrome://accessibility Not working in Electron 5+
2 participants
@codebytere @deepak1556