Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clipboard.readBuffer returning empty value #24454

Merged
merged 1 commit into from
Jul 8, 2020
Merged

fix: clipboard.readBuffer returning empty value #24454

merged 1 commit into from
Jul 8, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jul 8, 2020 •
edited

Description of Change

Fixes #24253

The implementation regressed with https://chromium-review.googlesource.com/c/chromium/src/+/1729965 where the upstream api now expects the raw format type.

Checklist

Release Notes

Notes: fix clipboard.readBuffer returning incorrect value

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 8, 2020
@deepak1556 deepak1556 requested a review from a team July 8, 2020 08:25
@deepak1556 deepak1556 merged commit 7dd3657 into master Jul 8, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 8, 2020

Release Notes Persisted

fix clipboard.readBuffer returning incorrect value

@deepak1556 deepak1556 deleted the robo/fix_clipboard_buffer branch July 8, 2020 22:02
This was referenced Jul 8, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 8, 2020

I have automatically backported this PR to "10-x-y", please check out #24467

@trop
Copy link
Contributor

trop bot commented Jul 8, 2020

I have automatically backported this PR to "8-x-y", please check out #24468

@trop
Copy link
Contributor

trop bot commented Jul 8, 2020

I have automatically backported this PR to "9-x-y", please check out #24469

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@deepak1556 @sentialx
fix: clipboard.readBuffer returning empty value (electron#24454)
abbfc86
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@deepak1556 @sentialx
fix: clipboard.readBuffer returning empty value (electron#24454)
d7ef2bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Electron 8: clipboard.writeBuffer is broken
2 participants
@deepak1556 @codebytere