build: update to standard 14 #24479
Merged
build: update to standard 14 #24479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
reviewed
Jul 9, 2020
There was a problem hiding this comment.
@MarshallOfSound why are we using standard for our documentation and prettier everywhere else? If we're already updating this and no longer use standard anywhere else it might be a good idea to align on the switch
|
@codebytere We don't use prettier at all in this repo, we use standard as the base for everything. Once all these dep bumps have landed I can look at pulling in prettier |
|
No Release Notes |
|
Oh i assumed we swapped when you enabled semicolons but that's eslint/ts - if that's not the case we should swap just to at least use the same rules in docs that we do in internal code |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what is says on the tin, updates our standard deps (standard-eslint-config + standard-markdown) to standard 14. The rest of the changes are automated as the result of
--fixNotes: no-notes