Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unresponsive window when reloading with breakpoint in devtools #24490

Merged
merged 2 commits into from Jul 13, 2020
Merged

fix: unresponsive window when reloading with breakpoint in devtools #24490

merged 2 commits into from Jul 13, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jul 9, 2020 •
edited

Description of Change

Backports https://chromium-review.googlesource.com/c/v8/v8/+/1924366

Refs microsoft/vscode#100740

Checklist

Release Notes

Notes: fix unresponsive window when reloading with breakpoint in devtools

@deepak1556 deepak1556 added 8-x-y backport-check-skip Skip trop's backport validity checking labels Jul 9, 2020
@deepak1556 deepak1556 requested a review from a team as a code owner July 9, 2020 23:18
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 9, 2020
@deepak1556 deepak1556 requested a review from a team July 10, 2020 16:49
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 10, 2020
jkleinsc
jkleinsc approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc jkleinsc merged commit 49e6394 into 8-x-y Jul 13, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 13, 2020

Release Notes Persisted

fix unresponsive window when reloading with breakpoint in devtools

@jkleinsc jkleinsc deleted the robo/fix_devtools_hang_8_x branch July 13, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @jkleinsc