New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings() #24494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
PR opened in the last 24 hours
and removed
new-pr 🌱
PR opened in the last 24 hours
labels
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have more tests for the launch_items
array
bitdisaster
reviewed
Jul 22, 2020
georgexu99
changed the title
[WIP] feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings()
feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings()
Jul 23, 2020
georgexu99
force-pushed
the
george/thingy
branch
from
July 23, 2020 22:37
208ecdc
to
23e9762
Compare
bitdisaster
reviewed
Jul 24, 2020
georgexu99
force-pushed
the
george/thingy
branch
from
July 28, 2020 19:13
b986a39
to
63e4548
Compare
georgexu99
force-pushed
the
george/thingy
branch
2 times, most recently
from
July 28, 2020 19:35
f7ebbba
to
b986a39
Compare
georgexu99
force-pushed
the
george/thingy
branch
from
July 28, 2020 19:58
b986a39
to
7c33881
Compare
MarshallOfSound
approved these changes
Jul 29, 2020
Release Notes Persisted
|
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Windows 10 introduced another way to deactivate but not delete a run key. A secondary registry key under HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run keeps track of whether the application is allowed to launch at start.
This api introduces the ability to determine whether an application is launched at login using additional information gathered from the windows registry location HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run.
Checklist
npm test
passesRelease Notes
Notes: changed app.getLoginItemSettings() and app.setLoginItemSettings() API to factor in startup approval keys when determining whether an application is able to launch on login