Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings() #24494

Merged
merged 3 commits into from Jul 29, 2020

Conversation

georgexu99
Copy link
Contributor

@georgexu99 georgexu99 commented Jul 10, 2020

Description of Change

Windows 10 introduced another way to deactivate but not delete a run key. A secondary registry key under HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run keeps track of whether the application is allowed to launch at start.
This api introduces the ability to determine whether an application is launched at login using additional information gathered from the windows registry location HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run.

Checklist

Release Notes

Notes: changed app.getLoginItemSettings() and app.setLoginItemSettings() API to factor in startup approval keys when determining whether an application is able to launch on login

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 10, 2020
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have more tests for the launch_items array

docs/api/app.md Outdated Show resolved Hide resolved
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
spec-main/api-app-spec.ts Outdated Show resolved Hide resolved
docs/api/app.md Outdated Show resolved Hide resolved
docs/api/app.md Outdated Show resolved Hide resolved
docs/api/app.md Outdated Show resolved Hide resolved
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
@georgexu99 georgexu99 changed the title [WIP] feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings() feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings() Jul 23, 2020
@georgexu99 georgexu99 marked this pull request as ready for review July 23, 2020 19:32
docs/api/app.md Outdated Show resolved Hide resolved
docs/api/app.md Outdated Show resolved Hide resolved
docs/api/app.md Outdated Show resolved Hide resolved
docs/api/app.md Outdated Show resolved Hide resolved
shell/browser/browser_win.cc Show resolved Hide resolved
spec-main/api-app-spec.ts Show resolved Hide resolved
@MarshallOfSound MarshallOfSound merged commit 1b175a0 into electron:master Jul 29, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 29, 2020

Release Notes Persisted

changed app.getLoginItemSettings() and app.setLoginItemSettings() API to factor in startup approval keys when determining whether an application is able to launch on login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants