build: tsify asar and move to webpack js2c pipeline #24495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
tsify-asar
branch
2 times, most recently
from
2bfa28f
to
328a290
Compare
nornagon
reviewed
Jul 10, 2020
nornagon
reviewed
Jul 10, 2020
nornagon
reviewed
Jul 10, 2020
There was a problem hiding this comment.
so much any 😭
i had a stab at this last week with less any and ended up finding bugs in the node typings (DefinitelyTyped/DefinitelyTyped#45783), so eh
codebytere
reviewed
Jul 11, 2020
MarshallOfSound
force-pushed
the
tsify-asar
branch
from
328a290
to
5a83e5b
Compare
|
Updated with strongly typed bindings |
codebytere
approved these changes
Jul 16, 2020
|
No Release Notes |
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
* build: tsify asar and move to webpack js2c pipeline * build: use the webpack provider for fs-wrapper
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
* build: tsify asar and move to webpack js2c pipeline * build: use the webpack provider for fs-wrapper
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
* build: tsify asar and move to webpack js2c pipeline * build: use the webpack provider for fs-wrapper
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
* build: tsify asar and move to webpack js2c pipeline * build: use the webpack provider for fs-wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the asar init scripts to typescript and move them to be processed by our webpack --> js2c pipeline.
Notes: no-notes