doc: Fix typos in MenuItem role values #24552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
ckerr
changed the title
ckerr
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
LGTM.
Looks like there's no One Correct Capitalization since the role strings are all converted to lowercase internally @ https://github.com/electron/electron/blob/master/lib/browser/api/menu-item.ts#L12.
Still, these roles are listed in camelCase in docs/api/menu-item.md and there's no reason to make the docs confusing by using inconsistent naming without reason. 👍
|
Ah, I got a capitalization error from TypeScript so maybe it's just the typings that want it camelCase. |
codebytere
changed the title
|
No Release Notes |
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix typos in role values for some menu items. They must have changed since the docs were originally made.
Checklist
Release Notes
Notes: none