chore: add Trop annotations to release notes. #24644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a savepoint commit; still need to display the data.
Trop annotations are in the form of "(Also in 7.3, 8, 9)" with links to the sibling branches.
jkleinsc
requested changes
Jul 20, 2020
sofianguy
reviewed
Jul 20, 2020
jkleinsc
approved these changes
Jul 21, 2020
|
No Release Notes |
ckerr
added a commit
that referenced
this pull request
Jul 21, 2020
Manually backport #24644 to 10-x-y. See that PR for details.
4 tasks
ckerr
added a commit
that referenced
this pull request
Jul 21, 2020
Manually backport #24644 to 10-x-y. See that PR for details.
5 tasks
ckerr
added a commit
that referenced
this pull request
Jul 21, 2020
Manually backport #24644 to 9-x-y. See that PR for details.
6 tasks
MarshallOfSound
added a commit
that referenced
this pull request
Jul 21, 2020
This reverts commit b43e601.
4 tasks
ckerr
added a commit
that referenced
this pull request
Jul 27, 2020
Manually backport #24644 to 7-3-x. See that PR for details.
5 tasks
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
* chore: add Trop annotations to release notes. Trop annotations are in the form of "(Also in 7.3, 8, 9)" with links to the sibling branches.
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
This reverts commit b43e601.
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
* chore: add Trop annotations to release notes. Trop annotations are in the form of "(Also in 7.3, 8, 9)" with links to the sibling branches.
georgexu99
pushed a commit
to georgexu99/electron
that referenced
this pull request
Jul 28, 2020
This reverts commit b43e601.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If a change lands in multiple branches, include that information in the release notes. Requested by @electron/wg-qa for the purposes of determining which changes in the release notes are multibranch and which are unique to a particular branch.
Sample output: https://hackmd.io/MONNN0QwRxKoMgAIMROUaw
This also has a happy side-effect: we no longer need the conditionals of showing a release note item based on whether the change is a beta and/or the change was in a previous branch, so this change eliminates a smelly edge case.
CC @electron/wg-qa @electron/wg-releases
Checklist
npm testpassesRelease Notes
Notes: none