refactor: ginify SystemPreferences #24675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (@available(macOS 10.14, *)) { | ||
| NSAppearance* appearance; | ||
| if (args->GetNext(&appearance)) { | ||
| [[NSApplication sharedApplication] setAppearance:appearance]; | ||
| } else { | ||
| args->ThrowError("Invalid app appearance provided as first argument"); | ||
| args->ThrowError(); |
There was a problem hiding this comment.
We've lost the Better Error here?
There was a problem hiding this comment.
Yeah, kinda. It matches other gin errors, "Conversion error at index 0". I'm on the fence as to whether consistency or descriptiveness wins here, as the error message here isn't much different to the default one that gin provides.
zcbenz
approved these changes
Jul 24, 2020
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: none