chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) #24687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
roller/chromium/master
branch
from
0c29a76
to
8147002
Compare
electron-bot
changed the title
codebytere
force-pushed
the
roller/chromium/master
branch
from
692c662
to
f5d3182
Compare
deepak1556
reviewed
Jul 24, 2020
| @@ -166,28 +166,28 @@ index a87c1992018071ecce8e4a640abebfeaf4e742eb..80ac0ab3b0edb12ca1846b8960143659 | |||
|
|
|||
| DCHECK_EQ(GL_TEXTURE0, GetActiveTextureUnit(gl_)); | |||
| gl_->BindTexture(GL_TEXTURE_EXTERNAL_OES, lock.texture_id()); | |||
deepak1556
reviewed
Jul 24, 2020
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
loc
force-pushed
the
roller/chromium/master
branch
from
f8288d9
to
60224be
Compare
electron-bot
changed the title
loc
force-pushed
the
roller/chromium/master
branch
from
db23f61
to
692c74a
Compare
electron-bot
changed the title
loc
force-pushed
the
roller/chromium/master
branch
2 times, most recently
from
26df6e0
to
372e966
Compare
loc
reviewed
Aug 8, 2020
electron-bot
changed the title
electron-bot
changed the title
electron-bot
changed the title
deepak1556
force-pushed
the
roller/chromium/master
branch
from
9843a94
to
37d22f8
Compare
deepak1556
force-pushed
the
roller/chromium/master
branch
from
7cec63a
to
b10689c
Compare
nornagon
reviewed
Aug 12, 2020
| const content::ConsoleMessage& message) { | ||
| v8::Isolate* isolate = JavascriptEnvironment::GetIsolate(); | ||
| v8::HandleScope scope(isolate); | ||
| v8::HandleScope handle_scope(isolate); | ||
| Emit("console-message", |
There was a problem hiding this comment.
Should we add scope to the event object?
There was a problem hiding this comment.
Seems like we do now https://github.com/electron/electron/blob/master/shell/common/gin_helper/event_emitter.h#L63 , can remove this in a follow-up PR.
nornagon
reviewed
Aug 12, 2020
| widget_host->Send(new WidgetMsg_EnableDeviceEmulation( | ||
| widget_host->GetRoutingID(), params)); | ||
| auto* widget_host_impl = | ||
| frame_host ? static_cast<content::RenderWidgetHostImpl*>( |
There was a problem hiding this comment.
oof, i don't love casting to the Impl. Can we do this without reaching into the internals?
There was a problem hiding this comment.
Unfortunately, the emulation apis are only reachable via the Impl class https://source.chromium.org/chromium/chromium/src/+/master:content/browser/devtools/protocol/emulation_handler.cc;l=553-563
this should be safe to cast https://source.chromium.org/chromium/chromium/src/+/master:content/browser/renderer_host/render_widget_host_impl.cc;l=510-512
nornagon
reviewed
Aug 12, 2020
| else if (screen_position == "desktop") | ||
| out->screen_position = blink::WebDeviceEmulationParams::kDesktop; | ||
| std::string screen_type; | ||
| if (dict.Get("screenPosition", &screen_type)) { |
There was a problem hiding this comment.
"screen position" is a weird name for this, but probably not worth it to change it.
nornagon
approved these changes
Aug 12, 2020
|
Failing woa test is unrelated, merging. |
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master).
See all changes in 1a093e6a0cb5e72ba78990fe39824..0e4ca9c0a63d7a39bd910997ad4c6
Notes: no-notes