fix: add handle scope in SelectClientCertificate #24868

zcbenz · 2020-08-06T00:56:31Z

Close #24851.

PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Notes: Fix crash when using client certificate.

release-clerk · 2020-08-07T03:50:46Z

Release Notes Persisted

Fix crash when using client certificate.

trop · 2020-08-07T03:51:13Z

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

trop · 2020-08-07T03:51:16Z

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

trop · 2020-08-18T16:12:46Z

@codebytere has manually backported this PR to "10-x-y", please check out #25019

fix: add handle scope in SelectClientCertificate

408c0b3

zcbenz requested a review from codebytere August 6, 2020 00:56

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 6, 2020

codebytere approved these changes Aug 6, 2020

View reviewed changes

deepak1556 added target/10-x-y labels Aug 6, 2020

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2020

codebytere merged commit 2224d94 into master Aug 7, 2020

codebytere deleted the client-cert-crash branch August 7, 2020 03:50

trop bot removed the target/10-x-y label Aug 7, 2020

trop bot added needs-manual-bp/10-x-y and removed target/9-x-y labels Aug 7, 2020

codebytere removed the needs-manual-bp/9-x-y label Aug 18, 2020

codebytere mentioned this pull request Aug 18, 2020

fix: add handle scope in SelectClientCertificate #25019

Merged

trop bot added in-flight/10-x-y and removed needs-manual-bp/10-x-y labels Aug 18, 2020

Provide feedback