Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: increase available space on mac arm64 vm #25008

Merged
merged 1 commit into from Aug 18, 2020

Conversation

MarshallOfSound
Copy link
Member

Really scrambling for space here 馃 idk if this is enough, we needed to find a spare ~4gigs I think and this is only ~2.5 so it might not be. But it's a good start.

Also fixes a thing where we were depending on the wrong v8 src files in one build step

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner August 17, 2020 21:53
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming release builds run fine

@MarshallOfSound MarshallOfSound force-pushed the moooooorreee-space branch 3 times, most recently from 12749e4 to f1fe666 Compare August 18, 2020 00:34
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeesh

@release-clerk
Copy link

release-clerk bot commented Aug 18, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the moooooorreee-space branch August 18, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants