Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix DCHECK on print job cancellation #25031

Merged
merged 1 commit into from Aug 20, 2020
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 19, 2020

Description of Change

Fixes the following DCHECK:

[25652:0818/224532.220407:FATAL:notification_registrar.cc(52)] Check failed: !IsRegistered(observer, type, source). Duplicate registration.

encountered as a result of callback_.is_null() being checked after std::move was called and so the notification observer not properly being removed.

cc @deepak1556 @zcbenz

Checklist

Release Notes

Notes: Fixed a potential crash on print job cancellation.

@codebytere codebytere requested a review from a team as a code owner August 19, 2020 05:55
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 19, 2020
@codebytere codebytere changed the title fix: DCHECK on print job cancellation chore: fix DCHECK on print job cancellation Aug 19, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 20, 2020
@zcbenz zcbenz merged commit 9631eaf into master Aug 20, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 20, 2020

Release Notes Persisted

Fixed a potential crash on print job cancellation.

@zcbenz zcbenz deleted the fix-printing-notif-dcheck branch August 20, 2020 06:28
@trop
Copy link
Contributor

trop bot commented Aug 20, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 25, 2020

@codebytere has manually backported this PR to "10-x-y", please check out #25131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants