Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow monospaced font styles to be specified for macOS tray titles #25059

Merged
merged 7 commits into from Aug 23, 2020

Conversation

alfredxing
Copy link
Contributor

Description of Change

Implements #22363 — add a parameter to tray.setTitle on macOS allowing the font type to optionally be specified as one of monospaced or monospacedDigit. The font attributes are set on the attributed string passed to the NSStatusItem.

Checklist

Release Notes

Notes: added optional parameter to specify monospaced font types for macOS tray titles

@welcome
Copy link

welcome bot commented Aug 20, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 20, 2020
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 😄

shell/browser/api/electron_api_tray.cc Outdated Show resolved Hide resolved
shell/browser/api/electron_api_tray.cc Outdated Show resolved Hide resolved
docs/api/tray.md Outdated Show resolved Hide resolved
@alfredxing alfredxing marked this pull request as ready for review August 20, 2020 17:12
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 21, 2020
@alfredxing
Copy link
Contributor Author

Updated! Is feat: the right prefix for PR feedback? 🤔

@MarshallOfSound
Copy link
Member

@alfredxing All PRs get squash merged so the semantic prefix doesn't super matter for additional commits. The prefix that is used is the prefix in the PR title, or if there is only a single commit the prefix in that commit. Because you have multiple commits the resultant squash will use the prefix from the PR title.

docs/api/tray.md Outdated Show resolved Hide resolved
shell/browser/api/electron_api_tray.cc Outdated Show resolved Hide resolved
shell/browser/api/electron_api_tray.cc Outdated Show resolved Hide resolved
shell/browser/api/electron_api_tray.cc Outdated Show resolved Hide resolved
@MarshallOfSound MarshallOfSound merged commit a23c66e into electron:master Aug 23, 2020
@welcome
Copy link

welcome bot commented Aug 23, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 23, 2020

Release Notes Persisted

added optional parameter to specify monospaced font types for macOS tray titles

@alfredxing alfredxing deleted the tray-font branch July 20, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants