New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow monospaced font styles to be specified for macOS tray titles #25059
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 😄
Updated! Is |
@alfredxing All PRs get squash merged so the semantic prefix doesn't super matter for additional commits. The prefix that is used is the prefix in the PR title, or if there is only a single commit the prefix in that commit. Because you have multiple commits the resultant squash will use the prefix from the PR title. |
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
Description of Change
Implements #22363 — add a parameter to
tray.setTitle
on macOS allowing the font type to optionally be specified as one ofmonospaced
ormonospacedDigit
. The font attributes are set on the attributed string passed to the NSStatusItem.Checklist
npm test
passesRelease Notes
Notes: added optional parameter to specify monospaced font types for macOS tray titles