Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to typescript 4 #25091

Merged
merged 1 commit into from Aug 24, 2020
Merged

build: update to typescript 4 #25091

merged 1 commit into from Aug 24, 2020

Conversation

MarshallOfSound
Copy link
Member

Lot's of fun stuff in typescript 4, this just updates us so we could in theory use it 馃槃

Notes: no-notes

@MarshallOfSound MarshallOfSound merged commit 8baa9de into master Aug 24, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 24, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the typescript-4 branch August 24, 2020 18:23
@vladimiry
Copy link

vladimiry commented Aug 31, 2020

Re 8baa9de#diff-dd0e415ac6643adc75f041a4617e141bR168-R174 I think this would be a more type-safe way since you don't cast stuff to any (ie props get enumerated in a type safe way):

for (const prop of ["Buffer", "setImmediate", "clearImmediate", "global", "root", "GLOBAL"] as const) {
    delete (global as Partial<Pick<typeof global, typeof prop>>)[prop];
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants