feat: make BrowserWindow vibrancy visual effect state customizable #25106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
6 tasks
codebytere
previously requested changes
Aug 24, 2020
| @@ -1451,7 +1474,14 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) { | |||
|
|
|||
| [effect_view setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable]; | |||
| [effect_view setBlendingMode:NSVisualEffectBlendingModeBehindWindow]; | |||
| [effect_view setState:NSVisualEffectStateFollowsWindowActiveState]; | |||
|
|
|||
| if (visual_effect_state_ == VisualEffectState::ACTIVE) { | |||
There was a problem hiding this comment.
Can we make this a switch so the compiler yells at you when you miss one of the enum options
There was a problem hiding this comment.
(Can be follow up to avoid blocking the minor)
MarshallOfSound
approved these changes
Aug 26, 2020
|
Release Notes Persisted
|
MarshallOfSound
deleted the
trop/10-x-y-bp-feat-make-browserwindow-vibrancy-visual-effect-state-customizable-1598283994400
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25083
See that PR for details.
Notes: Add
visualEffectStateoption to BrowserWindows to allow customization of vibrancy effect state on macOS.