Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mitigate use of private macOS font API #25117

Merged
merged 1 commit into from Aug 26, 2020
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 25, 2020

Description of Change

Closes #25115.

Fixes an issue where apps could be rejected in MAS becuase of the presence of a new private API: CGFontRenderingGetFontSmoothingDisabled(). The feature was added to ensure that macOS LCD text behavior was respected, but as it causes rejections we should disable the feature on MAS builds.

cc @MarshallOfSound @zcbenz

Checklist

Release Notes

Notes: Fixed an issue where some apps might be rejected from the Mac App Store owing to a private font-related API added in Chromium.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 25, 2020
@codebytere codebytere changed the title chore: patch out private macOS font API fix: patch out private macOS font API Aug 25, 2020
@codebytere codebytere changed the title fix: patch out private macOS font API fix: mitigate use of private macOS font API Aug 25, 2020
@codebytere codebytere force-pushed the patch-out-private branch 2 times, most recently from 290cec6 to e129b0a Compare August 25, 2020 05:54
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not enough to ensure we don't use it, we need to avoid linking to that symbol. We need to patch out it's usage

@codebytere codebytere added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 26, 2020
@codebytere
Copy link
Member Author

Failure is

chromium features PDF Viewer opens when loading a pdf resource in a iframe - opens when loading a pdf resource in a iframe
/Users/distiller/project/src/electron/spec-main/chromium-spec.ts
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/distiller/project/src/electron/spec-main/chromium-spec.ts)
    at listOnTimeout (internal/timers.js:549:17)
    at processTimers (internal/timers.js:492:7)

which has previously been seen and is not related.

@codebytere codebytere merged commit be8db58 into master Aug 26, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 26, 2020

Release Notes Persisted

Fixed an issue where some apps might be rejected from the Mac App Store owing to a private font-related API added in Chromium.

@codebytere codebytere deleted the patch-out-private branch August 26, 2020 04:13
@trop
Copy link
Contributor

trop bot commented Aug 26, 2020

I have automatically backported this PR to "10-x-y", please check out #25137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron 10.0.0 App Store Rejected - Private API - Framework/_CGFontRenderingGetFontSmoothingDisabled
3 participants