New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mitigate use of private macOS font API #25117
Conversation
290cec6
to
e129b0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not enough to ensure we don't use it, we need to avoid linking to that symbol. We need to patch out it's usage
e129b0a
to
1927eae
Compare
1927eae
to
abbecd2
Compare
abbecd2
to
daadbb0
Compare
Failure is
which has previously been seen and is not related. |
Release Notes Persisted
|
I have automatically backported this PR to "10-x-y", please check out #25137 |
Description of Change
Closes #25115.
Fixes an issue where apps could be rejected in MAS becuase of the presence of a new private API:
CGFontRenderingGetFontSmoothingDisabled()
. The feature was added to ensure that macOS LCD text behavior was respected, but as it causes rejections we should disable the feature on MAS builds.cc @MarshallOfSound @zcbenz
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where some apps might be rejected from the Mac App Store owing to a private font-related API added in Chromium.