Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix DCHECK on print job cancellation #25131

Merged
merged 2 commits into from
Aug 26, 2020
Merged

chore: fix DCHECK on print job cancellation #25131

merged 2 commits into from
Aug 26, 2020

Conversation

codebytere
Copy link
Member

Backport of #25031.

See that PR for more details.

Notes: Fixed a potential crash on print job cancellation.

@codebytere codebytere requested a review from a team as a code owner August 25, 2020 23:30
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 25, 2020
@trop trop bot mentioned this pull request Aug 25, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Aug 25, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 25, 2020
@codebytere codebytere merged commit 7cc0cb4 into 10-x-y Aug 26, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 26, 2020

Release Notes Persisted

Fixed a potential crash on print job cancellation.

@codebytere codebytere deleted the printing-dcheck-10 branch August 26, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound