chore: deprecate remote #25293
Merged
chore: deprecate remote #25293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +50,25 @@ If your crash ingestion server does not support compressed payloads, you can | |||
| turn off compression by specifying `{ compress: false }` in the crash reporter | |||
| options. | |||
|
|
|||
| ### Deprecated: `remote` module | |||
|
|
|||
| The `remote` module is deprecated in Electron 12, and will be removed in | |||
There was a problem hiding this comment.
Can we utilize this message to further indicate that you shouldn't just replace and forget. Let's use it as another chance to educate why using remote is bad.
There was a problem hiding this comment.
The @electron/remote repository has a big warning at the top. I think that's enough.
| import { browserModuleNames } from '@electron/internal/browser/api/module-names'; | ||
| import { commonModuleList } from '@electron/internal/common/api/module-list'; | ||
|
|
||
| deprecate.log('The remote module is deprecated. Use https://github.com/electron/remote instead.'); |
jkleinsc
requested changes
Sep 3, 2020
There was a problem hiding this comment.
We should also update this doc to note that remote is deprecated:
https://www.electronjs.org/docs/api/remote
codebytere
approved these changes
Sep 4, 2020
zcbenz
approved these changes
Sep 8, 2020
|
Release Notes Persisted
|
mlaurencin
pushed a commit
to mlaurencin/electron
that referenced
this pull request
Sep 16, 2020
TheCrether
added a commit
to TermFTP/TermFTP-Client
that referenced
this pull request
Nov 25, 2021
only breaking changes were how the remote API is called (@electron/remote) electron/electron#25293 in order for react imports to work, `contextIsolation` has to be set to `false`, since it is `true` by default now
TheCrether
added a commit
to TermFTP/TermFTP-Client
that referenced
this pull request
Nov 25, 2021
only breaking changes were how the remote API is called (@electron/remote) electron/electron#25293 in order for react imports to work, `contextIsolation` has to be set to `false`, since it is `true` by default now
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Ref #21408.
This adds a new deprecation warning message when
require('electron').remoteis encountered.Checklist
npm testpassesRelease Notes
Notes: Deprecated the
remotemodule. It is replaced by@electron/remote.