fix: handle electron script errors better #25331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
MarshallOfSound
approved these changes
Sep 4, 2020
zcbenz
approved these changes
Sep 8, 2020
|
No Release Notes |
zcbenz
deleted the
trop/11-x-y-bp-fix-handle-electron-script-errors-better-1599256458140
branch
MarshallOfSound
added a commit
that referenced
this pull request
Sep 14, 2020
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
MarshallOfSound
added a commit
that referenced
this pull request
Sep 14, 2020
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
MarshallOfSound
added a commit
that referenced
this pull request
Sep 14, 2020
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
MarshallOfSound
added a commit
that referenced
this pull request
Sep 14, 2020
MarshallOfSound
added a commit
that referenced
this pull request
Sep 14, 2020
MarshallOfSound
added a commit
that referenced
this pull request
Sep 14, 2020
adill
pushed a commit
to discord/electron
that referenced
this pull request
Sep 24, 2020
…25454) Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
adill
pushed a commit
to discord/electron
that referenced
this pull request
Sep 24, 2020
…25454) Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25328
See that PR for details.
Notes: no-notes