Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce flakiness in pdf test #25407

Merged
merged 1 commit into from
Sep 10, 2020
Merged

test: reduce flakiness in pdf test #25407

merged 1 commit into from
Sep 10, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Sep 10, 2020

Description of Change

This is a bit hacky, since really we ought to wait for the pdf frame to load, but I haven't been able to reproduce this test failing locally so I'm not sure what situation is causing it to fail.

For now, as this is one of our flakier tests, I think on balance there will be less total pain if we remove (what I assume is) the flaky bit from this test. Perhaps this is masking another bug, but I don't know what it is if so.

Checklist

Release Notes

Notes: none

@samuelmaddock
Copy link
Member

After #25385 is merged, the extension-ready event can be awaited for when the PDF extension is fully loaded. If the flakiness is caused by it not yet being loaded, this could fix it.

@nornagon
Copy link
Member Author

@samuelmaddock interesting, i'm not sure that's the case though as the pdf extension is a built-in extension, so it should be ready before any web contents are created, right?

@nornagon nornagon merged commit cd455c8 into master Sep 10, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 10, 2020

No Release Notes

@jkleinsc jkleinsc deleted the fix-flaky-pdf-test branch September 14, 2020 20:04
mlaurencin pushed a commit to mlaurencin/electron that referenced this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants