Update dialog.md with info about filter extensions #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some confusion about the correct way to add an `All Files` filter (see electron#2525), so I added it to the example. Also added a short note about the extension syntax. This is related to PR electron#2547.
| ] | ||
| } | ||
| ``` | ||
| The `extensions` array should contain extensions without wildcards or dots (e.g. `'png'` is good, `'.png'` and `'*.png'` are bad). To show all files, use the `'*'` wildcard (no other wildcard is supported). |
There was a problem hiding this comment.
The columns of line should be no greater than 80 characters.
|
Thanks for the following updated work! |
|
@hokein, it's fixed. |
|
Thanks! |
zcbenz
added a commit
that referenced
this pull request
Aug 25, 2015
Update dialog.md with info about filter extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion about the correct way to add an
All Filesfilter (see #2525), so I added it to the example.Also added a short note about the extension syntax.
This is related to PR #2547.