Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gdi printing in silent printing mode #25744

Merged

Conversation

RobertBorg
Copy link
Contributor

backport of #25679

Release Notes

Notes: fix: gdi printing in silent printing mode

for windows print_text_with_gdi is set to the value of is_modifiable
but this code path is not taken for silent printing
@RobertBorg RobertBorg requested a review from a team as a code owner October 2, 2020 09:36
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 2, 2020
@trop trop bot mentioned this pull request Oct 2, 2020
4 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Oct 2, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 2, 2020
@codebytere codebytere merged commit 639fb15 into electron:11-x-y Oct 2, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 2, 2020

Release Notes Persisted

fix: gdi printing in silent printing mode

@RobertBorg RobertBorg deleted the 11-x-y_fix_silent_gdi_printing branch October 5, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants