Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nativeImage.crop().toBitmap() returning garbage #25773

Merged
merged 1 commit into from Oct 6, 2020
Merged

fix: nativeImage.crop().toBitmap() returning garbage #25773

merged 1 commit into from Oct 6, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 5, 2020

Backport of #25757

See that PR for details.

Notes: Fixed NativeImage.crop().toBitmap() returning incorrect data.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 5, 2020
@trop trop bot requested a review from nornagon October 5, 2020 16:23
@trop trop bot mentioned this pull request Oct 5, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 5, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 5, 2020
@zcbenz zcbenz merged commit 244f405 into 10-x-y Oct 6, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 6, 2020

Release Notes Persisted

Fixed NativeImage.crop().toBitmap() returning incorrect data.

@zcbenz zcbenz deleted the trop/10-x-y-bp-fix-nativeimage-crop-tobitmap-returning-garbage-1601914992712 branch October 6, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @zcbenz