Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve app 'session-created' event spec #25804

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 7, 2020

Backport of #25799. Depends on #25798

See that PR for details.

Notes: no-notes

@trop trop bot requested a review from miniak October 7, 2020 14:00
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 7, 2020
@codebytere
Copy link
Member

@miniak this appears to need some work

@ckerr
Copy link
Member

ckerr commented Oct 8, 2020

Agree w/ @codebytere, these test fails appear to be related to the patch:

TypeError: Illegal invocation: Function must be called on an object of type Session
    at formatProperty (electron/node_modules/chai/lib/chai/utils/inspect.js:294:31)
    at /home/builduser/project/src/electron/node_modules/chai/lib/chai/utils/inspect.js:190:14
    at Array.map (<anonymous>)
    at formatValue (electron/node_modules/chai/lib/chai/utils/inspect.js:189:19)
    at inspect (electron/node_modules/chai/lib/chai/utils/inspect.js:32:10)
    at objDisplay (electron/node_modules/chai/lib/chai/utils/objDisplay.js:28:13)
    at /home/builduser/project/src/electron/node_modules/chai/lib/chai/utils/getMessage.js:47:48
    at String.replace (<anonymous>)
    at Object.getMessage (electron/node_modules/chai/lib/chai/utils/getMessage.js:47:6)
    at Proxy.Assertion.assert (electron/node_modules/chai/lib/chai/assertion.js:139:18)

Likely there's some difference between the tests in master and here?

@miniak
Copy link
Contributor

miniak commented Oct 8, 2020

@codebytere, @ckerr this is expected, it's catching a problem #25798 is fixing and that needs to be merged first

@miniak miniak force-pushed the trop/10-x-y-bp-test-improve-app-session-created-event-spec-1602079196761 branch from 667f7fe to 384e53c Compare October 8, 2020 21:36
@miniak
Copy link
Contributor

miniak commented Oct 9, 2020

@codebytere, @ckerr rebased this PR, the test is now passing

@codebytere
Copy link
Member

chrome extensions does not crash when using chrome.management

is unrelated

@codebytere codebytere merged commit 624ea4b into 10-x-y Oct 9, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 9, 2020

No Release Notes

@codebytere codebytere deleted the trop/10-x-y-bp-test-improve-app-session-created-event-spec-1602079196761 branch October 9, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants