Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: notifications successfully never timeout with included flag #25926

Merged
merged 2 commits into from Oct 13, 2020
Merged

fix: notifications successfully never timeout with included flag #25926

merged 2 commits into from Oct 13, 2020

Conversation

mlaurencin
Copy link
Contributor

Description of Change

Backport of #25820

@codebytere

Checklist

Release Notes

Notes: Fixed an issue where Windows notifications with timeoutType of 'never' did not work properly.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 13, 2020
@trop trop bot mentioned this pull request Oct 13, 2020
Merged
4 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 13, 2020
@codebytere codebytere merged commit fe94fd0 into electron:10-x-y Oct 13, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 13, 2020

Release Notes Persisted

Fixed an issue where Windows notifications with timeoutType of 'never' did not work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlaurencin @codebytere