Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectronBrowserMainParts wakes up every minute even if everything is idle #25954

Closed
ckerr opened this issue Oct 14, 2020 · 2 comments · Fixed by #25958
Closed

ElectronBrowserMainParts wakes up every minute even if everything is idle #25954

ckerr opened this issue Oct 14, 2020 · 2 comments · Fixed by #25958
Assignees

Comments

@ckerr
Copy link
Member

ckerr commented Oct 14, 2020

Found while investigating #25021

ElectronBrowserMainParts has a periodic timer that is used to trigger GC once a minute even on an idle system. While one wakeup per minute isn't bad, it's also been in there since 2014 and may or may not still be necessary. It might be worth seeing what happens to memory overhead if this is disabled and/or triggered with a different mechanism.

  // Start idle gc.
  gc_timer_.Start(
      FROM_HERE, base::TimeDelta::FromMinutes(1),
      base::Bind(&v8::Isolate::LowMemoryNotification,
                 base::Unretained(js_env_->isolate())));
@nornagon
Copy link
Member

I'd support a PR that removes this, I don't think it's needed.

@ckerr ckerr self-assigned this Oct 14, 2020
@zcbenz
Copy link
Member

zcbenz commented Oct 15, 2020

I'm good removing the idle GC, there has actually been no measurement whether it would be good for memory usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants