Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release NSAlert properly #26100

Merged
merged 1 commit into from Oct 22, 2020
Merged

fix: release NSAlert properly #26100

merged 1 commit into from Oct 22, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 22, 2020

Backport of #26078

See that PR for details.

Notes: Fix memory leak on macOS when using dialog.showMessageBox API.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 22, 2020
@trop trop bot requested a review from zcbenz October 22, 2020 06:49
@trop trop bot mentioned this pull request Oct 22, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Oct 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 22, 2020
@MarshallOfSound MarshallOfSound merged commit ce178d4 into 8-x-y Oct 22, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 22, 2020

Release Notes Persisted

Fix memory leak on macOS when using dialog.showMessageBox API.

@MarshallOfSound MarshallOfSound deleted the trop/8-x-y-bp-fix-release-nsalert-properly-1603349317569 branch October 22, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @MarshallOfSound @zcbenz