Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick 8f5a08079948 from chromium #26469

Merged
merged 2 commits into from Nov 13, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Nov 12, 2020

Expose a11y popup menu type via the name "AXPopupValue" on Mac

This value was exposed via the name "AXHasPopupValue", while WebKit
exposes this value via "AXPopupValue." Fix the attribute name, which in
turn fixes an issue with how popup buttons are announced in VoiceOver.

Bug: 1129678
Change-Id: Iede26b2fd6ddb9d7717fcb47fd1dd1cce5b74075
AX-Relnotes: Fix an issue with the announcement of popup buttons in VoiceOver.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489985
Commit-Queue: Aaron Leventhal aleventhal@chromium.org
Reviewed-by: Aaron Leventhal aleventhal@chromium.org
Cr-Commit-Position: refs/heads/master@{#820964}

Notes: Backported fix for https://crbug.com/1129678.

@nornagon nornagon requested a review from a team as a code owner November 12, 2020 16:55
@nornagon nornagon added 11-x-y backport-check-skip Skip trop's backport validity checking labels Nov 12, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Nov 12, 2020
@nornagon nornagon changed the title chore: cherry-pick 8f5a08079948 from chromium fix: cherry-pick 8f5a08079948 from chromium Nov 12, 2020
@nornagon nornagon merged commit 612acc0 into 11-x-y Nov 13, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 13, 2020

Release Notes Persisted

Backported fix for https://crbug.com/1129678.

@nornagon nornagon deleted the cherry-pick/11-x-y/chromium/8f5a08079948 branch November 13, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants