Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 275865e8c237 from chromium #26470

Merged
merged 4 commits into from Nov 16, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Nov 12, 2020

Mac: Target a11y actions on certain containers to focused or activedescendant children

When an action is triggered on a container with selectable children and
that container has a focused or activedescendant child, retarget the
action to that child. This fixes an issue where when the VoiceOver
cursor is on a tree with a focused child, triggered context menus would
use the tree as the target element.

menu on a tree instead of a focused child.

Bug: 1114892
Change-Id: Ibe580beed93aeaac54d1dabaee28443b290fd0e2
AX-Relnotes: Fix an issue where VoiceOver would trigger a context
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466281
Commit-Queue: Martin Robinson mrobinson@igalia.com
Reviewed-by: Scott Violet sky@chromium.org
Reviewed-by: Dominic Mazzoni dmazzoni@chromium.org
Reviewed-by: Nektarios Paisios nektar@chromium.org
Cr-Commit-Position: refs/heads/master@{#818831}

Notes: Backported fix for https://crbug.com/1114892.

@nornagon nornagon requested a review from a team as a code owner November 12, 2020 16:56
@nornagon nornagon added 11-x-y backport-check-skip Skip trop's backport validity checking labels Nov 12, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Nov 12, 2020
@jkleinsc
Copy link
Contributor

Merging as CI failures are unrelated to PR change.

@jkleinsc jkleinsc merged commit 38fab63 into 11-x-y Nov 16, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 16, 2020

Release Notes Persisted

Backported fix for https://crbug.com/1114892.

@jkleinsc jkleinsc deleted the cherry-pick/11-x-y/chromium/275865e8c237 branch November 16, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants