Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: segfault on webContents.fromId(xxx) #26652

Merged
merged 1 commit into from Nov 23, 2020
Merged

fix: segfault on webContents.fromId(xxx) #26652

merged 1 commit into from Nov 23, 2020

Conversation

nornagon
Copy link
Member

Backport of #26609.

Notes: Fixed a crash when calling webContents.fromId with an unknown ID.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2020
@trop trop bot mentioned this pull request Nov 23, 2020
Merged
5 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Nov 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2020
@codebytere codebytere changed the title fix: segfault on webContents.fromId(xxx) (#26609) fix: segfault on webContents.fromId(xxx) Nov 23, 2020
@codebytere codebytere merged commit 2a6c3bb into 11-x-y Nov 23, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 23, 2020

Release Notes Persisted

Fixed a crash when calling webContents.fromId with an unknown ID.

@codebytere codebytere deleted the backport/11-x-y/web-contents-fromid branch November 23, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
11-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @codebytere