Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 47e21abe349a from chromium #26653

Merged
merged 2 commits into from Nov 23, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Nov 23, 2020

Improve AXTextStateChangeType in NSAccessibilitySelectedTextChangedNotification

When setting the AXTextStateChangeType key in the user info data
structure for the notification, use AXTextStateChangeTypeSelectionMove
when we detect a focus change. This causes VoiceOver to properly
announce the label and type of form entries when their contents are
selected due to focus changes.

type are now announced.

Bug: 1127421
Change-Id: I42d66ad60fbcba7c8c34396fdbc3f6e0c739d1a2
AX-Relnotes: When focus changes moves to form inputs, the input label and
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512913
Commit-Queue: Martin Robinson mrobinson@igalia.com
Reviewed-by: Nektarios Paisios nektar@chromium.org
Cr-Commit-Position: refs/heads/master@{#829380}

Notes: Backported fix for https://crbug.com/1127421.

@nornagon nornagon requested a review from a team as a code owner November 23, 2020 18:45
@nornagon nornagon added 12-x-y backport-check-skip Skip trop's backport validity checking labels Nov 23, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Nov 23, 2020
@jkleinsc jkleinsc merged commit 46441c1 into 12-x-y Nov 23, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 23, 2020

Release Notes Persisted

Backported fix for https://crbug.com/1127421.

@nornagon nornagon deleted the cherry-pick/12-x-y/chromium/47e21abe349a branch November 23, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants