Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use all-for-one goma #26699

Merged
merged 2 commits into from Nov 30, 2020
Merged

build: use all-for-one goma #26699

merged 2 commits into from Nov 30, 2020

Conversation

MarshallOfSound
Copy link
Member

Reland with more files on macOS

Notes: no-notes

@MarshallOfSound MarshallOfSound merged commit 7d49ce8 into master Nov 30, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 30, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the goma-all-for-one branch November 30, 2020 20:29
@trop
Copy link
Contributor

trop bot commented Nov 30, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/10-x-y label Nov 30, 2020
@trop
Copy link
Contributor

trop bot commented Nov 30, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Nov 30, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Nov 30, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Nov 30, 2020

I have automatically backported this PR to "12-x-y", please check out #26741

MarshallOfSound added a commit that referenced this pull request Dec 1, 2020
@MarshallOfSound
build: use all-for-one goma (#26699)
6600327 
* Revert "Revert "build: use one-for-all goma (#26679)" (#26689)"

This reverts commit 38ab829.

* build: ensure file descriptor limit is higher on macOS
@MarshallOfSound MarshallOfSound mentioned this pull request Dec 1, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Dec 1, 2020

@MarshallOfSound has manually backported this PR to "master", please check out #26770

@trop trop bot added the in-flight/master label Dec 1, 2020
@trop
Copy link
Contributor

trop bot commented Dec 1, 2020

@MarshallOfSound has manually backported this PR to "11-x-y", please check out #26770

MarshallOfSound added a commit that referenced this pull request Dec 1, 2020
@MarshallOfSound
build: use all-for-one goma (#26699)
bb65b66 
* Revert "Revert "build: use one-for-all goma (#26679)" (#26689)"

This reverts commit 38ab829.

* build: ensure file descriptor limit is higher on macOS
jkleinsc pushed a commit that referenced this pull request Dec 2, 2020
@MarshallOfSound
build: use all-for-one goma (#26699) (#26770)
75cdd02 
* Revert "Revert "build: use one-for-all goma (#26679)" (#26689)"

This reverts commit 38ab829.

* build: ensure file descriptor limit is higher on macOS
trop bot pushed a commit that referenced this pull request Dec 2, 2020
@MarshallOfSound @electron-bot
build: use all-for-one goma (#26699)
04da80e 
* Revert "Revert "build: use one-for-all goma (#26679)" (#26689)"

This reverts commit 38ab829.

* build: ensure file descriptor limit is higher on macOS
trop bot pushed a commit that referenced this pull request Dec 2, 2020
@MarshallOfSound @electron-bot
build: use all-for-one goma (#26699)
1d11f7d 
* Revert "Revert "build: use one-for-all goma (#26679)" (#26689)"

This reverts commit 38ab829.

* build: ensure file descriptor limit is higher on macOS
MarshallOfSound added a commit that referenced this pull request Dec 2, 2020
@trop @MarshallOfSound
build: use all-for-one goma (#26699) (#26800)
24a1234 
* Revert "Revert "build: use one-for-all goma (#26679)" (#26689)"

This reverts commit 38ab829.

* build: ensure file descriptor limit is higher on macOS

Co-authored-by: Samuel Attard <sam@electronjs.org>
MarshallOfSound added a commit that referenced this pull request Dec 3, 2020
@trop @MarshallOfSound
build: use all-for-one goma (#26699) (#26799)
5604037 
* Revert "Revert "build: use one-for-all goma (#26679)" (#26689)"

This reverts commit 38ab829.

* build: ensure file descriptor limit is higher on macOS

Co-authored-by: Samuel Attard <sam@electronjs.org>
@jkleinsc
Copy link
Contributor

#26799 manually backported this to 10-x-y and #26800 manually backported this to 9-x-y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @jkleinsc