Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: internalModuleReadJSON for unpacked JSON #26750

Merged
merged 1 commit into from Dec 2, 2020
Merged

fix: internalModuleReadJSON for unpacked JSON #26750

merged 1 commit into from Dec 2, 2020

Conversation

vadim-termius
Copy link
Contributor

@vadim-termius vadim-termius commented Dec 1, 2020 •
edited

Backport of #26749.

See that PR for details.

Notes: Fixed import of unpacked node modules.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 1, 2020
@trop trop bot mentioned this pull request Dec 1, 2020
Merged
4 tasks
@trop trop bot added 12-x-y backport This is a backport PR labels Dec 1, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 1, 2020
@ckerr ckerr added the backport-check-skip Skip trop's backport validity checking label Dec 1, 2020
@ckerr ckerr merged commit c0f0a02 into electron:12-x-y Dec 2, 2020
@welcome
Copy link

welcome bot commented Dec 2, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Dec 2, 2020

Release Notes Persisted

Fixed import of unpacked node modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vadim-termius @ckerr