Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webFrameMain.send() / webFrameMain.postMessage() #26807

Merged
merged 1 commit into from Jan 15, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Dec 3, 2020

Description of Change

Add webFrameMain.send() / webFrameMain.postMessage().

Checklist

Release Notes

Notes: Added webFrameMain.send() / webFrameMain.postMessage().

@miniak miniak added the wip ⚒ label Dec 3, 2020
@miniak miniak self-assigned this Dec 3, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 3, 2020
@miniak miniak force-pushed the miniak/web-frame-main-send branch 2 times, most recently from 6d0e7ef to 91d6bee Compare December 3, 2020 16:41
@MarshallOfSound MarshallOfSound added the semver/minor backwards-compatible functionality label Dec 3, 2020
@MarshallOfSound MarshallOfSound added semver/minor backwards-compatible functionality and removed api-review/requested 🗳 semver/minor backwards-compatible functionality labels Dec 3, 2020
@MarshallOfSound MarshallOfSound added semver/minor backwards-compatible functionality and removed semver/minor backwards-compatible functionality api-review/requested 🗳 labels Dec 3, 2020
@miniak miniak force-pushed the miniak/web-frame-main-send branch 2 times, most recently from 2f216a6 to 96bb921 Compare December 3, 2020 22:23
@miniak miniak removed the wip ⚒ label Dec 3, 2020
@miniak miniak marked this pull request as ready for review December 3, 2020 23:23
@miniak miniak force-pushed the miniak/web-frame-main-send branch 2 times, most recently from d7287e7 to 534655b Compare December 4, 2020 02:26
@canibaltrol

This comment has been minimized.

@miniak miniak force-pushed the miniak/web-frame-main-send branch 2 times, most recently from 5e196ed to c3e8d09 Compare January 5, 2021 20:49
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const [port] = e.ports
// ...
})
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this

@jeremypointer7
Copy link

jeremypointer7 commented Jan 8, 2021 via email

Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@zcbenz zcbenz merged commit 2be3d03 into master Jan 15, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 15, 2021

Release Notes Persisted

Added webFrameMain.send() / webFrameMain.postMessage().

@zcbenz zcbenz deleted the miniak/web-frame-main-send branch January 15, 2021 00:00
@trop
Copy link
Contributor

trop bot commented Jan 15, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 18, 2021

@miniak has manually backported this PR to "12-x-y", please check out #27354

@trop
Copy link
Contributor

trop bot commented Jan 19, 2021

@miniak has manually backported this PR to "12-x-y", please check out #27366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review/approved ✅ semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants