Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message #26808

Merged
merged 1 commit into from Dec 4, 2020
Merged

fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message #26808

merged 1 commit into from Dec 4, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Dec 3, 2020 •
edited

Description of Change

IPC_MESSAGES.RENDERER_RELEASE_CALLBACK is an internal IPC message and needs to be sent via _sendToFrameInternal().
This regression was introduced in #24115.

Checklist

Release Notes

Notes: Fixed callbacks passed via the remote module not being released after all references are dropped.

@miniak miniak requested a review from nornagon as a code owner December 3, 2020 02:03
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 3, 2020
@miniak miniak self-assigned this Dec 3, 2020
@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Dec 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 4, 2020
@alexeykuzmin alexeykuzmin merged commit b111bba into master Dec 4, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 4, 2020

Release Notes Persisted

Fixed callbacks passed via the remote module not being released after all references are dropped.

@alexeykuzmin alexeykuzmin deleted the miniak/fix-remote-release-callback branch December 4, 2020 16:09
@trop
Copy link
Contributor

trop bot commented Dec 4, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Dec 4, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Dec 4, 2020

I have automatically backported this PR to "12-x-y", please check out #26833

miniak added a commit that referenced this pull request Dec 4, 2020
@miniak
fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message (#…
d79f68e 
…26808)
@miniak miniak mentioned this pull request Dec 4, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Dec 4, 2020

@miniak has manually backported this PR to "11-x-y", please check out #26836

miniak added a commit that referenced this pull request Dec 8, 2020
@miniak
fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message (#…
8e55e49 
…26808)
zcbenz pushed a commit that referenced this pull request Dec 8, 2020
@miniak
fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message (#…
2c325cd 
…26808) (#26836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@miniak miniak

Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @nornagon @deepak1556 @MarshallOfSound @alexeykuzmin