Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message #26833

Merged
merged 1 commit into from Dec 4, 2020
Merged

fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message #26833

merged 1 commit into from Dec 4, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 4, 2020

Backport of #26808

See that PR for details.

Notes: Fixed callbacks passed via the remote module not being released after all references are dropped.

@trop trop bot requested a review from nornagon as a code owner December 4, 2020 16:09
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 4, 2020
@trop trop bot requested a review from miniak December 4, 2020 16:09
@trop trop bot mentioned this pull request Dec 4, 2020
Merged
3 tasks
@trop trop bot added 12-x-y backport This is a backport PR labels Dec 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 4, 2020
@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Dec 4, 2020
@MarshallOfSound MarshallOfSound merged commit 9543f8b into 12-x-y Dec 4, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 4, 2020

Release Notes Persisted

Fixed callbacks passed via the remote module not being released after all references are dropped.

@trop trop bot deleted the trop/12-x-y-bp-fix-send-ipc_messages-renderer_release_callback-as-internal-message-1607098173775 branch December 4, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon nornagon is a code owner

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @MarshallOfSound