Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick b84b4f3323b from chromium #26963

Merged
merged 2 commits into from Dec 14, 2020

Conversation

nornagon
Copy link
Member

Description of Change

Fixes #26946.

This broke with #26196, which backported an incomplete fix for
https://crbug.com/1128657.

Notes: Fixed an issue with audio not playing in HTML video elements.

@nornagon nornagon requested a review from a team as a code owner December 11, 2020 20:26
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 11, 2020
@nornagon nornagon added the backport-check-skip Skip trop's backport validity checking label Dec 11, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 11, 2020
@nornagon nornagon added semver/patch backwards-compatible bug fixes 10-x-y labels Dec 11, 2020
@jkleinsc jkleinsc merged commit 7b0bb0b into 10-x-y Dec 14, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 14, 2020

Release Notes Persisted

Fixed an issue with audio not playing in HTML video elements.

@jkleinsc jkleinsc deleted the cherry-pick/10-x-y/chromium/b84b4f3323b branch December 14, 2020 18:01
yinzhou2018 pushed a commit to yinzhou2018/electron that referenced this pull request Dec 15, 2020
@omerdoron1
Copy link

@jkleinsc can you please release a hot fix for electron 10 with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants