Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly emit after hooks after exception #26991

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 14, 2020

Backport of #26752

See that PR for details.

Notes: Fixed an issue where some async_hooks were not properly emitted after an error in the renderer process.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 14, 2020
@trop trop bot requested a review from codebytere December 14, 2020 16:27
@trop trop bot added 11-x-y backport This is a backport PR labels Dec 14, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 14, 2020
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Dec 14, 2020
@codebytere
Copy link
Member

Failure is not related.

@codebytere codebytere merged commit c4e8c0f into 11-x-y Dec 14, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 14, 2020

Release Notes Persisted

Fixed an issue where some async_hooks were not properly emitted after an error in the renderer process.

@trop trop bot deleted the trop/11-x-y-bp-fix-properly-emit-after-hooks-after-exception-1607963262806 branch December 14, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant