Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove last use of InternalCallbackScope #27050

Merged
merged 2 commits into from Dec 17, 2020
Merged

refactor: remove last use of InternalCallbackScope #27050

merged 2 commits into from Dec 17, 2020

Conversation

codebytere
Copy link
Member

Backport of #27029.

See that PR for details.

Notes: none.

@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Dec 16, 2020
@codebytere codebytere requested a review from a team as a code owner December 16, 2020 20:14
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 16, 2020
@trop trop bot mentioned this pull request Dec 16, 2020
Merged
3 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Dec 16, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 16, 2020
@ckerr
Copy link
Member

ckerr commented Dec 17, 2020

win-ia32-testing CI failure is reported flake #26045

@ckerr ckerr merged commit e012f61 into 11-x-y Dec 17, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 17, 2020

No Release Notes

@ckerr ckerr deleted the remove-last-internalcbscope-11 branch December 17, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @ckerr @zcbenz @electron-bot