fix: prevent crash when keyboard event immediately precedes calling BrowserWindow.close() #27358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Activating a key to close a window will cause a silent crash. Handling the keyboard event will lead to a nullptr dereferenced in Chromium code if the window widget has already been destroyed.
Merged
4 tasks
trop
bot
added
10-x-y
backport
codebytere
approved these changes
Jan 19, 2021
zcbenz
approved these changes
Jan 19, 2021
|
Release Notes Persisted
|
zcbenz
deleted the
trop/10-x-y-bp-fix-prevent-crash-when-keyboard-event-immediately-precedes-calling-browserwindow-close--1611023895913
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #27315
See that PR for details.
Notes: Fixed crash when a keyboard event immediately precedes calling
browserWindow.close()on Windows.